diff --git a/src/main/java/de/ctdo/bunti/artnet/ByteUtils.java b/src/main/java/de/ctdo/bunti/artnet/ByteUtils.java index c702647..10c0232 100644 --- a/src/main/java/de/ctdo/bunti/artnet/ByteUtils.java +++ b/src/main/java/de/ctdo/bunti/artnet/ByteUtils.java @@ -28,7 +28,7 @@ public class ByteUtils { private final byte[] data; public ByteUtils(byte[] data) { - this.data = data; + this.data = data.clone(); } public static int byteToUint(byte b) { @@ -40,7 +40,7 @@ public class ByteUtils { } public final byte[] getBytes() { - return data; + return data.clone(); } public final int getInt16(int offset) { diff --git a/src/main/java/de/ctdo/bunti/artnet/packets/ArtNetPacket.java b/src/main/java/de/ctdo/bunti/artnet/packets/ArtNetPacket.java index a63e753..2beaae6 100644 --- a/src/main/java/de/ctdo/bunti/artnet/packets/ArtNetPacket.java +++ b/src/main/java/de/ctdo/bunti/artnet/packets/ArtNetPacket.java @@ -37,7 +37,7 @@ public abstract class ArtNetPacket { } public final void setData(byte[] data) { - this.data = new ByteUtils(data); + this.data = new ByteUtils(data.clone()); } public final PacketType getType() { diff --git a/src/main/java/de/ctdo/bunti/artnet/packets/PacketType.java b/src/main/java/de/ctdo/bunti/artnet/packets/PacketType.java index 874e8d3..a5c3dd8 100644 --- a/src/main/java/de/ctdo/bunti/artnet/packets/PacketType.java +++ b/src/main/java/de/ctdo/bunti/artnet/packets/PacketType.java @@ -19,6 +19,9 @@ package de.ctdo.bunti.artnet.packets; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + public enum PacketType { ART_POLL(0x2000, null), @@ -47,6 +50,8 @@ public enum PacketType { private final int opCode; private final Class packetClass; + private static final Logger LOGGER = LoggerFactory.getLogger(PacketType.class); + private PacketType(int code, Class clazz) { opCode = code; @@ -59,9 +64,9 @@ public enum PacketType { try { p = packetClass.newInstance(); } catch (InstantiationException e) { - e.printStackTrace(); + LOGGER.error("Could not instanciate ArtNetPacket: ",e); } catch (IllegalAccessException e) { - e.printStackTrace(); + LOGGER.error("Could not instanciate ArtNetPacket: ",e); } } return p; diff --git a/src/main/java/de/ctdo/bunti/model/BuntiDevice.java b/src/main/java/de/ctdo/bunti/model/BuntiDevice.java index c275e12..4bcb9d3 100644 --- a/src/main/java/de/ctdo/bunti/model/BuntiDevice.java +++ b/src/main/java/de/ctdo/bunti/model/BuntiDevice.java @@ -27,12 +27,12 @@ public abstract class BuntiDevice { */ @Transient public final String getType() { - String FQClassName = this.getClass().getName(); - int firstChar = FQClassName.lastIndexOf ('.') + 1; + String fqClassName = this.getClass().getName(); + int firstChar = fqClassName.lastIndexOf ('.') + 1; if ( firstChar > 0 ) { - FQClassName = FQClassName.substring ( firstChar ); + fqClassName = fqClassName.substring ( firstChar ); } - return FQClassName; + return fqClassName; } /**